Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BetterErrors/better_errors
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: DropMyEmail/better_errors
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 31, 2016

  1. Attempt to fix #305 "undefined method `id'"-Error 

    I use better_errors and subsequent requests to the better_errors
middleware, e.g. trying to access the basic REPL depend on the instance
variable `@error_page` to be present in the BetterErrors::Middleware
instance.

Though as far as I understand the Rack- and BetterErrors-Code the
@error_page object is not "persisted" for inter-request access and right
now I dont understand how this usually works e.g. in a rails app
environment.

Nevertheless. My attempt to fix this is introducing a class variable
`latest_error_page` that serves as a temporary inter-request storage.
The current test suite does not brake and it fixes my problem.

I'd love to have some feedback about the inner workings of better_errors
and if @charliesome finds the time a little explanation how the
`@error_page` object is usually persisted for inter-request access.
    Gregory Igelmund committed Mar 31, 2016
    Configuration menu
    Copy the full SHA
    c557196 View commit details
    Browse the repository at this point in the history
Loading