Skip to content

Define defaultValue for font-size to allow overwriting it.#4235

Closed
buuhuu wants to merge 1 commit into
NativeScript:masterfrom
buuhuu:master
Closed

Define defaultValue for font-size to allow overwriting it.#4235
buuhuu wants to merge 1 commit into
NativeScript:masterfrom
buuhuu:master

Conversation

@buuhuu

@buuhuu buuhuu commented May 19, 2017

Copy link
Copy Markdown
Contributor

Relates to #4234.

I tested that on my app and it works as expected. Though I cannot estimate side effects

@ns-bot

ns-bot commented May 19, 2017

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

@ns-bot ns-bot added the cla: no label May 19, 2017
@ns-bot

ns-bot commented May 19, 2017

Copy link
Copy Markdown

CLA signature found, happy contributing!

@ns-bot ns-bot added cla: yes and removed cla: no labels May 19, 2017
@buuhuu buuhuu mentioned this pull request May 22, 2017
Closed
@vakrilov

vakrilov commented May 25, 2017

Copy link
Copy Markdown
Contributor

run ci

@vchimev

vchimev commented May 26, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey @buuhuu,

there is a failing unit test for Android only:

I/JS      ( 1712): === ALL TESTS COMPLETE ===
I/JS      ( 1712): 1441 OK, 1 failed
E/JS      ( 1712): Test: TAB-VIEW.test_FontIsReappliedWhenTabItemsChange FAILED: Font must be the original one after resetting the style. [typeface] Actual: <null>(object). Expected: <android.graphics.Typeface@a5f25733>(object)

I would like to execute our UI tests suites in order to measure the side effects (if any) before getting this merged.

CC: @vakrilov

@vchimev

vchimev commented May 26, 2017

Copy link
Copy Markdown
Contributor

uitests

@vakrilov

vakrilov commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

Hi @buuhuu
Thanks for the contribution. However - let's first try to understand what the problem is (see #4234).
When we know what the issue is, we would be able to write a proper unit test and assure that it is solved for good.

@vakrilov

vakrilov commented Jun 12, 2017

Copy link
Copy Markdown
Contributor

Closing due to inactivity - please reopen needed.

@vakrilov vakrilov closed this Jun 12, 2017
@lock

lock Bot commented Aug 27, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@buuhuu @ns-bot @vakrilov @vchimev