Skip to content

Missing 'until' params #1429

Open
mortharia wants to merge 2 commits into
docker-java:mainfrom
mortharia:LogContainerCmd_until_param
Open

Missing 'until' params #1429
mortharia wants to merge 2 commits into
docker-java:mainfrom
mortharia:LogContainerCmd_until_param

Conversation

@mortharia

@mortharia mortharia commented Jul 7, 2020

Copy link
Copy Markdown

fix #1427


This change is Reviewable

@mortharia mortharia changed the title Add LogContainerCmd until param Missing until params #1427 Jul 7, 2020
@mortharia mortharia changed the title Missing until params #1427 Missing until params Jul 7, 2020
@mortharia mortharia changed the title Missing until params Missing 'until' params Jul 7, 2020
@stale

stale Bot commented Aug 7, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot closed this Aug 14, 2020
@mortharia mortharia changed the title Missing 'until' params Missing 'until' params Nov 24, 2020
@bsideup bsideup reopened this Sep 13, 2021
@bsideup

bsideup commented Sep 13, 2021

Copy link
Copy Markdown
Member

@mortharia sorry for letting it stale. Could you please change the test to not use Thread.sleeps? Thank you!

@stale stale Bot removed the resolution/stale label Sep 13, 2021
assertThat(container.getId(), not(is(emptyString())));

dockerRule.getClient().startContainerCmd(container.getId()).exec();
Thread.sleep(5000);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Awaitility instead

@eddumelendez eddumelendez requested a review from a team as a code owner August 19, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing until params

3 participants