Skip to content

Update org.apache.httpcomponents.client5:httpclient5 to >= 5.3.1#2262

Closed
strangelookingnerd wants to merge 1 commit into
docker-java:mainfrom
strangelookingnerd:bump_httpclient5
Closed

Update org.apache.httpcomponents.client5:httpclient5 to >= 5.3.1#2262
strangelookingnerd wants to merge 1 commit into
docker-java:mainfrom
strangelookingnerd:bump_httpclient5

Conversation

@strangelookingnerd

@strangelookingnerd strangelookingnerd commented Dec 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Supersedes #2261 and #2185
Fixes #2183

I'm currently trying to solve jenkinsci/docker-plugin#1032 and found that docker-java may not be compatible with httpclient5 > 5.2.1
Unfortunately I am unable to 100% validate this on my machine due to #2174

I removed the exclusion of org.apache.httpcomponents.core5:httpcore5-h2 since I do not see a reason why it should be excluded in the first place it seems like that in recent versions of the httpclient the dependencies changed and excluding org.apache.httpcomponents.core5:httpcore5-h2 causes

java.lang.NoClassDefFoundError: Could not initialize class org.apache.hc.client5.http.config.TlsConfig

	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.resolveTlsConfig(PoolingHttpClientConnectionManager.java:276)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:441)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:162)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:172)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:142)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:96)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:152)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:115)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:87)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:191)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClient.execute(ApacheDockerHttpClient.java:9)
	at com.github.dockerjava.transport.DockerHttpClientTCK.ping(DockerHttpClientTCK.java:110)
	at com.github.dockerjava.transport.DockerHttpClientTCK.testPath(DockerHttpClientTCK.java:75)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NoClassDefFoundError: org/apache/hc/core5/http2/HttpVersionPolicy [in thread "docker-java-stream--314008509"]
	at org.apache.hc.client5.http.config.TlsConfig$Builder.build(TlsConfig.java:211)
	at org.apache.hc.client5.http.config.TlsConfig.<clinit>(TlsConfig.java:47)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.resolveTlsConfig(PoolingHttpClientConnectionManager.java:276)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:441)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:162)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:172)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:142)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:96)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:152)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:115)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:87)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:191)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClient.execute(ApacheDockerHttpClient.java:9)
	at com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:228)
	at com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)
	at java.base/java.lang.Thread.run(Thread.java:840)

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner December 3, 2023 16:47
@strangelookingnerd strangelookingnerd mentioned this pull request Dec 3, 2023
Closed
@strangelookingnerd strangelookingnerd changed the title Bump org.apache.httpcomponents.client5:httpclient5 from 5.0.3 to 5.2.3 Update org.apache.httpcomponents.client5:httpclient5 to >= 5.2.3 Dec 4, 2023
@strangelookingnerd strangelookingnerd mentioned this pull request Jan 3, 2024
Closed
@fsdrw08

fsdrw08 commented Jan 15, 2024

Copy link
Copy Markdown

/approve

@strangelookingnerd

strangelookingnerd commented Jan 16, 2024

Copy link
Copy Markdown
Author

Pinging maintainers

@docker-java-maintain
@marcuslinke
@KostyaSha
@kpelykh
@bsideup

Would someone be able to take a look at this PR or the growing number of issues and PR for the same problem? Thanks in advance.

@strangelookingnerd strangelookingnerd changed the title Update org.apache.httpcomponents.client5:httpclient5 to >= 5.2.3 Update org.apache.httpcomponents.client5:httpclient5 to >= 5.3.1 Jan 25, 2024
@gounthar

gounthar commented Jan 25, 2024

Copy link
Copy Markdown

A fix has been released, thanks for the update @strangelookingnerd .

gounthar
gounthar approved these changes Jan 25, 2024
View reviewed changes

@gounthar gounthar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🤞

@strangelookingnerd

strangelookingnerd commented Apr 17, 2024

Copy link
Copy Markdown
Author

Obsolete with #2294 and #2272. Closing it.

@strangelookingnerd strangelookingnerd deleted the bump_httpclient5 branch April 17, 2024 16:34
@strangelookingnerd strangelookingnerd mentioned this pull request Oct 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gounthar gounthar gounthar approved these changes

@fsdrw08 fsdrw08 fsdrw08 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

core5 HttpVersionPolicy NoClassDefFoundError

3 participants

@strangelookingnerd @fsdrw08 @gounthar