[AI] Use hybrid tag for prefer_in_cloud instances.#7857
Conversation
To correctly tag hybrid request, not only `prefer_on_device` must be tagged, but also `prefer_in_cloud`, since it's not the default configuration and shows an intent to use the feature. Internal b/489062704
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
There was a problem hiding this comment.
Code Review
This pull request correctly updates the logic for tagging hybrid requests to include PREFER_IN_CLOUD mode. The renaming of the isFallback parameter to isHybrid is a good change that improves code clarity. The new tests provide good coverage for the changes. I have one minor suggestion to refactor the new test code to improve its structure and reduce duplication.
To correctly tag hybrid request, not only
prefer_on_devicemust be tagged, but alsoprefer_in_cloud, since it's not the default configuration and shows an intent to use the feature.Internal b/489062704