Skip to content

feat: add first, last, arrayAgg and arrayAggDistinct expressions#7893

Merged
yvonnep165 merged 11 commits into
mainfrom
yvonne/accumulators-expressions
Mar 16, 2026
Merged

feat: add first, last, arrayAgg and arrayAggDistinct expressions#7893
yvonnep165 merged 11 commits into
mainfrom
yvonne/accumulators-expressions

Conversation

@yvonnep165
Copy link
Copy Markdown
Contributor

@yvonnep165 yvonnep165 commented Mar 10, 2026

Adds support for the accumulators pipeline expressions: first, last, arrayAgg and arrayAggDistinct.

ported from firebase/firebase-js-sdk#9576

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 10, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@yvonnep165 yvonnep165 requested review from dlarocque and milaGGL March 10, 2026 20:59
@milaGGL
Copy link
Copy Markdown
Contributor

milaGGL commented Mar 12, 2026

please run ./gradlew :firebase-firestore:spotlessApply to format the code

@yvonnep165
Copy link
Copy Markdown
Contributor Author

yvonnep165 commented Mar 12, 2026 •
edited
Loading

please run ./gradlew :firebase-firestore:spotlessApply to format the code

ok done!

milaGGL
milaGGL approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise LGTM

@yvonnep165 yvonnep165 merged commit 34bf169 into main Mar 16, 2026
27 of 29 checks passed
@yvonnep165 yvonnep165 deleted the yvonne/accumulators-expressions branch March 16, 2026 20:03
@firebase firebase locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dlarocque dlarocque dlarocque approved these changes

@milaGGL milaGGL milaGGL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yvonnep165 @milaGGL @dlarocque