Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: use insecure grpc channel with emulator#946

Merged
daniel-sanche merged 6 commits into
googleapis:mainfrom
daniel-sanche:insecure_emulator
Apr 11, 2024
Merged

fix: use insecure grpc channel with emulator#946
daniel-sanche merged 6 commits into
googleapis:mainfrom
daniel-sanche:insecure_emulator

Conversation

@daniel-sanche
Copy link
Copy Markdown
Contributor

Uses insecure channels for the emulator for the sync client, as there are problems with secure channels on some platforms/environments.

This change was also made in firestore: googleapis/python-firestore#402

Fixes #755

@daniel-sanche daniel-sanche requested review from a team March 19, 2024 23:53
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 19, 2024
Comment thread google/cloud/bigtable/client.py Outdated

def _emulator_channel(self, transport, options):
"""Create a channel using self._credentials
"""Create a channelfor use with the Bigtable emulator.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in channelfor

@daniel-sanche daniel-sanche merged commit aa31706 into googleapis:main Apr 11, 2024
@daniel-sanche daniel-sanche deleted the insecure_emulator branch April 11, 2024 18:58
@mattthym
Copy link
Copy Markdown

@daniel-sanche Thank you so much for this! 💐
This makes running tests against the bigtable-emulator in CI/CD pipelines so much easier 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support connecting to bigtable emulator running on separate container/machine

4 participants