Skip to content

OSGI - Make org.jspecify.* imports optional#3949

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
schulm:feature/org-jspecify-optional
May 6, 2025
Merged

OSGI - Make org.jspecify.* imports optional#3949
bbakerman merged 1 commit into
graphql-java:masterfrom
schulm:feature/org-jspecify-optional

Conversation

@schulm

@schulm schulm commented May 5, 2025

Copy link
Copy Markdown

Since org.specify import is not necessarily needed at runtime, can we make it optional?

@andimarek

Copy link
Copy Markdown
Member

@schulm sounds reasonable.

@dondonz @bbakerman thoughts?

@bbakerman

Copy link
Copy Markdown
Member

Yeah we should add this.

@bbakerman bbakerman self-requested a review May 6, 2025 00:38

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many use OSGI any more but why not

@bbakerman bbakerman added this to the 24.0 milestone May 6, 2025
@bbakerman bbakerman merged commit 5f07138 into graphql-java:master May 6, 2025
1 check passed
@schulm

schulm commented May 6, 2025

Copy link
Copy Markdown
Author

@bbakerman Thanks, would you also have a look at graphql-java/java-dataloader#194

@schulm schulm mentioned this pull request May 8, 2025
dondonz added a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants