Skip to content

Functions#230

Merged
vplentinax merged 31 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-function-basics
Jul 3, 2020
Merged

Functions#230
vplentinax merged 31 commits into
javascript-tutorial:masterfrom
vplentinax:Giorgiosaud-function-basics

Conversation

@vplentinax

@vplentinax vplentinax commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Functions #96 . Dicho PR será cerrado y reenumerado en el Issue 17.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 5, 2020 17:34
@vplentinax vplentinax changed the title Giorgiosaud-PR95-correccion Conditional operators: if, '?' Jun 5, 2020
@vplentinax vplentinax changed the title Conditional operators: if, '?' Functions Jun 5, 2020

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casi listo, algunas correcciones

Comment thread 1-js/02-first-steps/15-function-basics/1-if-else-required/task.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/2-rewrite-function-question-or/task.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 16 commits June 15, 2020 11:05
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax

Copy link
Copy Markdown
Contributor Author

/done

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varios cambiecitos
Pero muy buen schooling, so dont wait for me
cambia lo que quieras y MERGE

Partimos de un falso "mucho hecho", resignamos a que eran menos de 20.
Ahora 60... ¡UN TERCIO DEL SITIO! Y los PR, dentro del mes.
Qué sino para festejo.

Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
vplentinax and others added 14 commits July 2, 2020 17:51
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 2, 2020 21:55
@vplentinax vplentinax merged commit ca8f297 into javascript-tutorial:master Jul 3, 2020
@javascript-translate-bot

Copy link
Copy Markdown

Error: the article has another translator @Giorgiosaud, not @vplentinax in the Progress Issue #17. Please update the progress issue or ask maintainers to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants