Skip to content

JSON methods, toJSON#278

Merged
EzequielCaste merged 18 commits into
javascript-tutorial:masterfrom
EzequielCaste:json-methods
Jul 13, 2020
Merged

JSON methods, toJSON#278
EzequielCaste merged 18 commits into
javascript-tutorial:masterfrom
EzequielCaste:json-methods

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

actualizados los nombres de archivos

@EzequielCaste EzequielCaste requested a review from vplentinax June 22, 2020 23:19
@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 23:19
@iliakan iliakan mentioned this pull request Jun 22, 2020
Open
joaquinelio
joaquinelio requested changes Jul 6, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://tools.ietf.org/html/rfc4627 no anda, pero el nombre está registrado quizas sea temporal

¿corrijo los signos de apertura? Español exige simetría ¿¿¡¡!!?? salvo ¡¡?? y (?)

Comment thread 1-js/05-data-types/12-json/2-serialize-event-circular/task.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 6, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 12 commits July 8, 2020 09:00
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/2-serialize-event-circular/task.md
67cf345 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
bef3826 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
77d8205 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
816e630 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
b7f2e14 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
222b916 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
c7e2b99 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
c523264 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
bff4acd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
eb3c914 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
6c398c1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
7e2be2b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
EzequielCaste
EzequielCaste commented Jul 8, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correcciones

@EzequielCaste EzequielCaste removed the request for review from vplentinax July 8, 2020 12:16
@EzequielCaste

EzequielCaste commented Jul 11, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 15:04
joaquinelio
joaquinelio requested changes Jul 12, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"request" para label correcto,
cosass menores, desp de eso que el 2do reviewer considere que lo apprové

Si le interesa a alguien, "there is no..." a veces se traduce "no está permitido".
No sé si es inglés general o una particcularidad yanqui
"There is no walking in the red zone"

Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
Comment thread 1-js/05-data-types/12-json/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 5 commits July 13, 2020 09:08
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
5f21aa8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
28fb630 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
91ab19c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
e63a07c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
3084859 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 13, 2020 12:15
EzequielCaste
EzequielCaste commented Jul 13, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

/done

@EzequielCaste EzequielCaste removed the request for review from a team July 13, 2020 12:20
@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

@joaquinelio

joaquinelio commented Jul 13, 2020

Copy link
Copy Markdown
Member

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

@ezzep66
Pfff reglas, reglas, reglas,
o el dedo que apunta a la luna, ¿lo que importa es el dedo? 😄

seriamente,
veras que apruuebo todo lo que veo terminado,
pero dejo el mensaje para alentarlos a obviar el paso robótico nomás, no porque no haya cumplido mi parte de review.
Si fuera código sería mucho más estricto.

joaquinelio
joaquinelio approved these changes Jul 13, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EzequielCaste EzequielCaste merged commit 29b4499 into javascript-tutorial:master Jul 13, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EzequielCaste @javascript-translate-bot @joaquinelio