Skip to content

DOM tree#188

Merged
mahdyar merged 50 commits into
javascript-tutorial:masterfrom
Beroozam:master
Jan 14, 2022
Merged

DOM tree#188
mahdyar merged 50 commits into
javascript-tutorial:masterfrom
Beroozam:master

Conversation

@Beroozam

@Beroozam Beroozam commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 7, 2022 19:26
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 7, 2022
Open
@mahdiHash

mahdiHash commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, @Beroozam.
Please open a pull request when the translation is ready.
Since the article and other files are not fully translated yet, I'll convert this PR to draft for now.
You can set it to "ready for review" whenever you're done translating.
Good luck!

@mahdiHash mahdiHash marked this pull request as draft January 7, 2022 20:40
@Beroozam Beroozam marked this pull request as ready for review January 12, 2022 19:25
@Beroozam

Beroozam commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

Thank you in advance for your guidance

mahdiHash
mahdiHash suggested changes Jan 13, 2022
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to batch and create a commit just once (docs).

Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Beroozam and others added 18 commits January 13, 2022 17:01
@Beroozam @mahdiHash
Update text nodes
302d352 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update new line
02a3112 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update half spaces2
5a881a1 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update half spaces3
4ac9870 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update half spaces4
d1803a7 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update new line === line break
d6c1b79 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update into or with
41cc0c5 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update new line again
640e9d9 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update 2-ui/1-document/02-dom-nodes/article.md
bd26c7f 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update it's there
311540f 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update from
53df22c 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update inspect
dbab746 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update real-time
e4b0614 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update how it's looks
d03c865 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update node types
dcdc1c2 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdyar
Update comment
74b67b1 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@Beroozam @mahdiHash
Update comments for comments
964b409 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@Beroozam @mahdiHash
Update debugging
65c8abe 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
Beroozam
Beroozam commented Jan 14, 2022
View reviewed changes

@Beroozam Beroozam left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review needed

Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
Comment thread 2-ui/1-document/02-dom-nodes/article.md Outdated
@Beroozam @mahdiHash
Apply suggestions from code review
acd407d 
Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@mahdiHash
Fix line counts conflicts and remove a word
285af35 
For the uniformity of articles, "خلاصه مطلب" is changed to "خلاصه".
@mahdiHash
Remove an empty line
1d4a01a
mahdiHash
mahdiHash approved these changes Jan 14, 2022
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @Beroozam.

mahdyar
mahdyar approved these changes Jan 14, 2022
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahdyar mahdyar merged commit 2f60a44 into javascript-tutorial:master Jan 14, 2022
@javascript-translate-bot

javascript-translate-bot commented Jan 14, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

+1 more reviewer

@mahdiHash mahdiHash mahdiHash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Beroozam @mahdiHash @javascript-translate-bot @mahdyar