Skip to content

Multiline mode of anchors ^ $, flag "m"#259

Merged
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master
Mar 15, 2023
Merged

Multiline mode of anchors ^ $, flag "m"#259
mahdyar merged 8 commits into
javascript-tutorial:masterfrom
EhsanShahbazii:master

Conversation

@EhsanShahbazii

Copy link
Copy Markdown
Contributor

/done

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mahdyar

mahdyar commented Mar 14, 2023

Copy link
Copy Markdown
Member

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

@EhsanShahbazii

Copy link
Copy Markdown
Contributor Author

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

In the previous article that we translated, we used the word "پرچم". Of course, in my opinion, it is better that the words flag and anchor are not translated. But because we translated in the previous article, that's why I also translated.

@mahdiHash

Copy link
Copy Markdown
Contributor

Sorry for the delay. I was a little busy.

I also think "flag" is better. But it's translated to "پرچم" in other articles, so we need to revert it in another PR.

For now, please left "flag" as is, @EhsanShahbazii.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii

Copy link
Copy Markdown
Contributor Author

/done

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii

Copy link
Copy Markdown
Contributor Author

/done

@mahdiHash

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

@mahdyar mahdyar merged commit b669507 into javascript-tutorial:master Mar 15, 2023
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants