Skip to content

Switch#61

Merged
mehradsadeghi merged 6 commits into
javascript-tutorial:masterfrom
newshahn:master
Jul 15, 2020
Merged

Switch#61
mehradsadeghi merged 6 commits into
javascript-tutorial:masterfrom
newshahn:master

Conversation

@newshahn

Copy link
Copy Markdown
Contributor

Hi,
Switch chapter was translated :)

Comment thread 1-js/02-first-steps/14-switch/1-rewrite-switch-if-else/task.md Outdated
Comment thread 1-js/02-first-steps/14-switch/2-rewrite-if-switch/task.md Outdated

@mehradsadeghi mehradsadeghi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple parts that you've changed single quotes to double quotes in the translations (in code sections). Is there any reason for that ? Am I missing something ?

@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@newshahn

Copy link
Copy Markdown
Contributor Author

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you

@mehradsadeghi

Copy link
Copy Markdown
Contributor

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you

Don't worry about it. You're doing fine.

@newshahn

Copy link
Copy Markdown
Contributor Author

Dear Mehrad,
I fixed the issues you mentioned in the past PR.
An extension was changing my double quotes to single quotes.
Hopefully, it's all okay now.

@mehradsadeghi mehradsadeghi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@mehradsadeghi mehradsadeghi merged commit 74cdde6 into javascript-tutorial:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants