Skip to content

Export and Import#243

Merged
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/export-import
Mar 7, 2021
Merged

Export and Import#243
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/export-import

Conversation

@longo-andrea

@longo-andrea longo-andrea commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 6, 2021 13:50
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 6, 2021
Open
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Dorin-David
Dorin-David suggested changes Mar 6, 2021
View reviewed changes

@Dorin-David Dorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--

@javascript-translate-bot

javascript-translate-bot commented Mar 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea @Dorin-David
Apply suggestions from code review
95bb5e4 
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

/done

pasor1
pasor1 approved these changes Mar 7, 2021
View reviewed changes

@pasor1 pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altra traduzione ben fatta 😉

Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
Comment thread 1-js/13-modules/02-import-export/article.md Outdated
@longo-andrea @pasor1
Apply suggestions from code review
0434d79 
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea longo-andrea merged commit aea07d9 into javascript-tutorial:master Mar 7, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 7, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea longo-andrea deleted the article/export-import branch March 7, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1 pasor1 pasor1 approved these changes

+1 more reviewer

@Dorin-David Dorin-David Dorin-David requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2nd review done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea @javascript-translate-bot @pasor1 @Dorin-David