Skip to content

The "switch" statement#108

Merged
jonnathan-ls merged 16 commits into
javascript-tutorial:masterfrom
odsantos:switch
Jun 25, 2023
Merged

The "switch" statement#108
jonnathan-ls merged 16 commits into
javascript-tutorial:masterfrom
odsantos:switch

Conversation

@odsantos

@odsantos odsantos commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

Add switch directory files translation.

@odsantos odsantos self-assigned this Feb 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team February 20, 2020 21:46
@javascript-translate-bot

javascript-translate-bot commented Feb 20, 2020

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1 ⁉️

@odsantos odsantos mentioned this pull request Mar 17, 2020
Closed
odsantos added 4 commits March 17, 2020 23:13
@odsantos
Update article.md
89ead44 
Add corrections to translation.
@odsantos
Update solution.md
87215a5 
Add corrections to translation.
@odsantos
Update task.md
988ea12 
Add corrections to translation.
@odsantos
Update solution.md
c8e18ce
@iliakan iliakan mentioned this pull request Mar 19, 2020
Open
@odsantos

odsantos commented Mar 19, 2020

Copy link
Copy Markdown
Contributor Author

The lesson had a former #57 PR merged by me.

@wnleao

wnleao commented May 9, 2020

Copy link
Copy Markdown
Contributor

Hey, @odsantos ! Could you update your commits with respect to the english version? https://github.com/javascript-tutorial/en.javascript.info/tree/master/1-js/02-first-steps/14-switch

@CLAassistant

CLAassistant commented May 15, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@odsantos

odsantos commented Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

Hey, @odsantos ! Could you update your commits with respect to the english version? https://github.com/javascript-tutorial/en.javascript.info/tree/master/1-js/02-first-steps/14-switch

Hi @kiniggit, I believe the files are now updated.
Thank you.

jonnathan-ls
jonnathan-ls requested changes Oct 14, 2022
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odsantos ... my review!

Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/2-rewrite-if-switch/task.md Outdated
Comment thread 1-js/02-first-steps/14-switch/2-rewrite-if-switch/solution.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 14, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos

odsantos commented Dec 4, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 4, 2022 22:44
odsantos
odsantos commented Dec 4, 2022
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address @jonnathan-ls requested changes.

jonnathan-ls
jonnathan-ls approved these changes Jun 25, 2023
View reviewed changes
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
Comment thread 1-js/02-first-steps/14-switch/article.md Outdated
@jonnathan-ls jonnathan-ls merged commit 6a52867 into javascript-tutorial:master Jun 25, 2023
@javascript-translate-bot

javascript-translate-bot commented Jun 25, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

+1 more reviewer

@exploitmik exploitmik exploitmik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odsantos odsantos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@odsantos @javascript-translate-bot @wnleao @CLAassistant @exploitmik @jonnathan-ls