Skip to content

Patterns and flags#147

Merged
nazarepiedady merged 14 commits into
javascript-tutorial:masterfrom
fsdude:01-regexp-introduction
Mar 10, 2024
Merged

Patterns and flags#147
nazarepiedady merged 14 commits into
javascript-tutorial:masterfrom
fsdude:01-regexp-introduction

Conversation

@fsdude

@fsdude fsdude commented May 28, 2020

Copy link
Copy Markdown
Contributor

Retranslation done. I removed 'article-pt.md' file too, just to keep the quantity of files same as the english.

@javascript-translate-bot javascript-translate-bot requested a review from a team May 28, 2020 00:04
@iliakan iliakan mentioned this pull request May 28, 2020
Open
odsantos
odsantos requested changes May 18, 2021
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate if any of you could review this PR #147 , including my revision.
Thank you.

Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 18, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

odsantos
odsantos reviewed Jul 14, 2021
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sine @fsdude is not available, I applied my own changes and will wait for another reviewer.

@odsantos

odsantos commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Hi @luizclr, @jonnathan-ls , @Mr-Saxobeat, since @fsdude might be unavailable I would appreciate if any of you could review this PR #147.
Thank you.

1 similar comment
@odsantos

odsantos commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Hi @luizclr, @jonnathan-ls , @Mr-Saxobeat, since @fsdude might be unavailable I would appreciate if any of you could review this PR #147.
Thank you.

@odsantos

odsantos commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

Hi @luizclr , @Mr-Saxobeat , @jonnathan-ls , anyone available for reviewing this PR #147 ? Thanks.

@peruibeloko

peruibeloko commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

@jonnathan-ls @odsantos esse PR também apresenta o mesmo problema da tradução do pattern:

@odsantos

odsantos commented Jan 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@peruibeloko I'll check and hopefully get back to you soon. Thanks.

@peruibeloko peruibeloko mentioned this pull request Jan 17, 2024
Merged
jonnathan-ls
jonnathan-ls approved these changes Jan 20, 2024
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Eu apliquei as atualizações de trechos que não devem ser traduzidos, conforme commit 91686e7

@jonnathan-ls

jonnathan-ls commented Jan 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

... esse PR também apresenta o mesmo problema da tradução do pattern:

Grato pela observação @peruibeloko ❤️

Eu apliquei o ajuste no último commit e na aprovação que deixei 91686e7 \done

@jonnathan-ls

jonnathan-ls commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

Hi ... anyone available for reviewing this PR #147 ? Thanks.

@odsantos eu adicionei minha aprovação e a observação que o Peruibeloko registrou de textos que não devem ser traduzidos.

Como você já tinha registrado sua revisão e realizou os ajustes necessários, por gentileza, registrar a aprovação de suas solicitações, para o BOT deste repositório conseguir observar e o status do PR estar condizente na marcação da lista de tarefas (issue 01).

Para registrar a aprovação de sua revisão, basta clicar nos três pontinhos de menu e atualizar com sua aprovação, para que possamos prosseguir com o Merge Request.

image

@nazarepiedady nazarepiedady requested review from a team February 5, 2024 16:34
nazarepiedady
nazarepiedady approved these changes Mar 10, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good enough to be approved, so I do it.

@nazarepiedady nazarepiedady merged commit 0218fe7 into javascript-tutorial:master Mar 10, 2024
@javascript-translate-bot

javascript-translate-bot commented Mar 10, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantos odsantos odsantos requested changes

@nazarepiedady nazarepiedady nazarepiedady approved these changes

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fsdude @javascript-translate-bot @odsantos @peruibeloko @jonnathan-ls @nazarepiedady