Skip to content

Property flags and descriptors#219

Merged
gabifs merged 11 commits into
javascript-tutorial:masterfrom
herbertpdl:master
Dec 2, 2025
Merged

Property flags and descriptors#219
gabifs merged 11 commits into
javascript-tutorial:masterfrom
herbertpdl:master

Conversation

@herbertpdl

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Jul 25, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @herbertpdl,

Here is a review.
Please, feel free to comment where you disagree.

Thank you.

Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl

Copy link
Copy Markdown
Contributor Author

@odsantos Done!

@odsantos

Copy link
Copy Markdown
Contributor

Hi @herbertpdl , the repository was updated and this branch has conflicts, so it also needs to be updated.
If you have time to do it, could you please comment in the end here as \done only?
It is the way the bot tracks the changes and alters from changes requested to pending review.
Thank you.

@herbertpdl

Copy link
Copy Markdown
Contributor Author

/done

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @herbertpdl,

Here is another review.

Thank you.

Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread 1-js/07-object-properties/01-property-descriptors/article.md
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl

Copy link
Copy Markdown
Contributor Author

/done

@odsantos

Copy link
Copy Markdown
Contributor

Hi @herbertpdl ,

Still working on this one.
There is conflict here.
If resolved I could try another review.

Thanks,
Osvaldo.

@nazarepiedady

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

@peruibeloko

Copy link
Copy Markdown
Contributor

@nazarepiedady his master branch is write protected, but I resolved all the conflicts here: https://github.com/Peruibeloko/pt.javascript.info/tree/herbertpdl/master

@nazarepiedady

Copy link
Copy Markdown
Member

@peruibeloko, could you copy his work, review it, and create your own pull request to solve this issue?

@peruibeloko

Copy link
Copy Markdown
Contributor

@nazarepiedady will do

@nazarepiedady

Copy link
Copy Markdown
Member

@gabifs

@gabifs gabifs merged commit 0424be5 into javascript-tutorial:master Dec 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants