Debugging in the browser#399
Conversation
|
Zenóbio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@zenobiopereira , it seems you took a translated article and are proposing changes. |
|
Hey @odsantos , yeah, it seems like the topic already had been translated but at least for me, the text was using multiple terms in which seems like PT-PT, even though, I would be glad if you could review it as proposed changes and if that's not possible then I can jump to translate a different topic. |
|
Hi @zenobiopereira , yes I'll try to review it as soon as possible. Thanks. |
Match original in English.
odsantos
left a comment
There was a problem hiding this comment.
Hi @zenobiopereira ,
Here is a review.
Please don't hesitate to tell me where you disagree.
Thank you,
Osvaldo.
odsantos
left a comment
There was a problem hiding this comment.
Hi @zenobiopereira ,
Here is a review.
Please don't hesitate to tell me where you disagree.
Thank you,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
|
Hey @odsantos thank you for the review, I did applied most of your corrections since pretty much all of them added context and small needed corrections. I've also left small comments in two requested changes just because I think the text as it is, already delivers the same meaning, please let me know what do you think in relation to those. Thank you in advance. |
|
/done |
|
Hi @zenobiopereira left a comment on the review point on discussion. Thanks. |
|
@odsantos Thank you in advance. /done |
|
Hi @zenobiopereira , will take a look as soon as possible. Thanks. |
jonnathan-ls
left a comment
There was a problem hiding this comment.
Embora, ainda considero que o artigo está em um linguajar muito formal, entendo que a necessidade deveria vir de outro momento para refletirmos em relação as colocações de escrita que este repositório em PT pode vir a adotar.
Sendo assim, considero a solicitação: LGTM ( Looks good to me )
|
Please make the requested changes. After it, add a comment "/done". |
|
@jonnathan-ls, the language should be formal because programming is science. |
nazarepiedady
left a comment
There was a problem hiding this comment.
It also looks good to me to be approved.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Translated it the best I could, please let me know if there are some kind of convention that I've broken or some kind of phrasing that doesn't seems good.
There's also the
hello.jsfile that I assume it should not have function names translated so I didn't touch it.