Skip to content

Dynamic imports#419

Merged
nazarepiedady merged 4 commits into
javascript-tutorial:masterfrom
danilolmc:update-dynamic-imports
Apr 8, 2024
Merged

Dynamic imports#419
nazarepiedady merged 4 commits into
javascript-tutorial:masterfrom
danilolmc:update-dynamic-imports

Conversation

@danilolmc

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread 1-js/13-modules/03-modules-dynamic-imports/say.view/index.html
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc danilolmc force-pushed the update-dynamic-imports branch from 342d4cd to 192eff9 Compare February 21, 2024 02:43
@danilolmc

Copy link
Copy Markdown
Contributor Author

/done

@nazarepiedady

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, could you review this pull request?

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added a commit with some adjustments such as pending translations 780f934

@jonnathan-ls

Copy link
Copy Markdown
Contributor

... could you review this pull request?

I added my review with contribution @nazarepiedady

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, so I will pass it forward.

@nazarepiedady nazarepiedady merged commit 60013b3 into javascript-tutorial:master Apr 8, 2024
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants