Skip to content

Anchors: string start ^ and end $#420

Merged
jonnathan-ls merged 6 commits into
javascript-tutorial:masterfrom
peruibeloko:09/04
Jan 29, 2024
Merged

Anchors: string start ^ and end $#420
jonnathan-ls merged 6 commits into
javascript-tutorial:masterfrom
peruibeloko:09/04

Conversation

@peruibeloko

Copy link
Copy Markdown
Contributor

Usarei os termos "casar", "casamento" e "correspondência" como tradução para "match" dependendo do contexto, mas quero evitar usar outros termos para evitar confusões.

No artigo como um todo, mas específicamente no trecho

In other words, they do not match a character, but rather force the regexp engine to check the condition (text start/end).

Faltou com uma explicação simples do que as âncoras realmente representam: uma posição, que foi o que adicionei na minha tradução:

Em outras palavras, elas não casam com um carácter, mas sim com uma posição, obrigando o interpretador regex a verificar a condição de início ou fim da string.

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review your changes, they are good in general, but there are some changes I would like you to look.

Comment thread 9-regular-expressions/04-regexp-anchors/1-start-end/task.md Outdated
Comment thread 9-regular-expressions/04-regexp-anchors/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko

Copy link
Copy Markdown
Contributor Author

These seem pretty reasonable, I'll get to it later today. Thanks for the review Nazaré!

@peruibeloko

Copy link
Copy Markdown
Contributor Author

/done

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems acceptable to me, so let's see what others maintainers have to say.

@peruibeloko

peruibeloko commented Jan 28, 2024

Copy link
Copy Markdown
Contributor Author

@jonnathan-ls Looks good to me! Thanks for fishing up the remaining bits

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko

Tomei a liberdade de traduzir o restante de trechos em ingles, conforme commit (56d7f23), tudo bem pra ti a alteração?

Com isso, está LGTM (Looks Good To Me) ...

@jonnathan-ls jonnathan-ls merged commit 1067461 into javascript-tutorial:master Jan 29, 2024
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@peruibeloko

Copy link
Copy Markdown
Contributor Author

@jonnathan-ls Tranquilo! Vou passar a traduzir esses trechos daqui em diante também. Obrigado pela força 🙏

@peruibeloko peruibeloko deleted the 09/04 branch February 2, 2024 23:18

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko, well done, we are moving forward finally. We have some more few pull requests to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants