Skip to content

Multiline mode of anchors ^ $, flag "m"#421

Merged
gabifs merged 5 commits into
javascript-tutorial:masterfrom
peruibeloko:09/05
Nov 25, 2025
Merged

Multiline mode of anchors ^ $, flag "m"#421
gabifs merged 5 commits into
javascript-tutorial:masterfrom
peruibeloko:09/05

Conversation

@peruibeloko

Copy link
Copy Markdown
Contributor

No description provided.

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko, could you evaluate the review I did?

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko

Copy link
Copy Markdown
Contributor Author

/done

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready to be applied.

@nazarepiedady

Copy link
Copy Markdown
Member

@danilolmc, @jonnathan-ls, could you help to review this pull request and approve it if it is okay?

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Outdated

@danilolmc danilolmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Droped just a single comment, not a big deal!

The PR LGTM!

@peruibeloko

Copy link
Copy Markdown
Contributor Author

@nazarepiedady Implemented the change, we're able to merge now!

@nazarepiedady

Copy link
Copy Markdown
Member

@peruibeloko, I need one person to approve the updates, this person does not need necessarily to be a maintainer, a regular contributor serves.

@nazarepiedady

Copy link
Copy Markdown
Member

@danilolmc, do you have time to approve these updates?

@nazarepiedady

Copy link
Copy Markdown
Member

@jonnathan-ls, could you approve these updates?

@gabifs gabifs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabifs gabifs merged commit bbbad0f into javascript-tutorial:master Nov 25, 2025
@peruibeloko peruibeloko deleted the 09/05 branch December 7, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants