Skip to content

findBaseCommitForFixup should apply scrolloff in the commits view #5243

Description

@Axlefublr

Describe the bug

Using findBaseCommitForFixup does jump to the commit, but it's not scrolled into view. Only once I ↓↑ in the view, I start to see the commit, which I find massively annoying.
Note that this is the behavior always. The commits view is not at all scrolled to accomodate the commit that you are jumped to. This is not a “in some cases” type of bug. More so, an underdevelopment.

compressed.mp4

Expected behavior

Once you are jumped on top of a commit in the commits view, and the commits view becomes active, the user-configured scrollOffMargin should be applied, so that the commit is in view.

Version info:

commit=80dd695d7, build date=20260109.023340, build source=unknown, version=v0.58.0.80dd695d7, os=linux, arch=amd64, git version=2.52.0

Terminal info:

foot terminal, version:

foot version: 1.25.0 +pgo +ime +graphemes -assertions

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions