Skip to content

type is a call#1942

Merged
ianhattendorf merged 1 commit into
nodegit:masterfrom
computational-science:master
Oct 31, 2022
Merged

type is a call#1942
ianhattendorf merged 1 commit into
nodegit:masterfrom
computational-science:master

Conversation

@axkibe

@axkibe axkibe commented Oct 13, 2022

Copy link
Copy Markdown

as per issue #1935

@zawata

zawata commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

huh. this has been busted for 4 years?

seems to be introduced in this commit:
adcc5c5 in PR #1671

@axkibe

axkibe commented Oct 18, 2022

Copy link
Copy Markdown
Author

It's a big library, and I guess not all functionality is constantly used, since the ALL worked I guess this is what most used and no one wanted DIRECT only. I only stumbled over this while doing some experiments, not sure if I'm not going for ALL anyway at the end.

@ianhattendorf ianhattendorf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Closes #1935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants