http,https: increase server headers timeout

timcosta · MylesBorins · commit 172228047a1c · 2019-12-17T18:17:20.000-05:00
Fixes: #24980 Refs: eb43bc04b1 PR-URL: #30071 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/doc/api/http.md b/doc/api/http.md
@@ -1107,7 +1107,7 @@ Stops the server from accepting new connections. See [`net.Server.close()`][].
 added: v11.3.0
 -->
 
-* {number} **Default:** `40000`
+* {number} **Default:** `60000`
 
 Limit the amount of time the parser will wait to receive the complete HTTP
 headers.
diff --git a/doc/api/https.md b/doc/api/https.md
@@ -94,7 +94,7 @@ See [`server.close()`][`http.close()`] from the HTTP module for details.
 added: v11.3.0
 -->
 
-* {number} **Default:** `40000`
+* {number} **Default:** `60000`
 
 See [`http.Server#headersTimeout`][].
 
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -348,7 +348,7 @@ function Server(options, requestListener) {
   this.timeout = 0;
   this.keepAliveTimeout = 5000;
   this.maxHeadersCount = null;
-  this.headersTimeout = 40 * 1000; // 40 seconds
+  this.headersTimeout = 60 * 1000; // 60 seconds
 }
 ObjectSetPrototypeOf(Server.prototype, net.Server.prototype);
 ObjectSetPrototypeOf(Server, net.Server);
diff --git a/lib/https.js b/lib/https.js
@@ -77,7 +77,7 @@ function Server(opts, requestListener) {
   this.timeout = 0;
   this.keepAliveTimeout = 5000;
   this.maxHeadersCount = null;
-  this.headersTimeout = 40 * 1000; // 40 seconds
+  this.headersTimeout = 60 * 1000; // 60 seconds
 }
 ObjectSetPrototypeOf(Server.prototype, tls.Server.prototype);
 ObjectSetPrototypeOf(Server, tls.Server);
diff --git a/test/parallel/test-http-slow-headers.js b/test/parallel/test-http-slow-headers.js
@@ -17,8 +17,8 @@ const headers =
 const server = createServer(common.mustNotCall());
 let sendCharEvery = 1000;
 
-// 40 seconds is the default
-assert.strictEqual(server.headersTimeout, 40 * 1000);
+// 60 seconds is the default
+assert.strictEqual(server.headersTimeout, 60 * 1000);
 
 // Pass a REAL env variable to shortening up the default
 // value which is 40s otherwise this is useful for manual
diff --git a/test/parallel/test-https-slow-headers.js b/test/parallel/test-https-slow-headers.js
@@ -27,8 +27,8 @@ const server = createServer({
 
 let sendCharEvery = 1000;
 
-// 40 seconds is the default
-assert.strictEqual(server.headersTimeout, 40 * 1000);
+// 60 seconds is the default
+assert.strictEqual(server.headersTimeout, 60 * 1000);
 
 // Pass a REAL env variable to shortening up the default
 // value which is 40s otherwise

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ function Server(options, requestListener) {`
`348`	`348`	`this.timeout = 0;`
`349`	`349`	`this.keepAliveTimeout = 5000;`
`350`	`350`	`this.maxHeadersCount = null;`
`351`		`- this.headersTimeout = 40 * 1000; // 40 seconds`
	`351`	`+ this.headersTimeout = 60 * 1000; // 60 seconds`
`352`	`352`	`}`
`353`	`353`	`ObjectSetPrototypeOf(Server.prototype, net.Server.prototype);`
`354`	`354`	`ObjectSetPrototypeOf(Server, net.Server);`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ function Server(opts, requestListener) {`
`77`	`77`	`this.timeout = 0;`
`78`	`78`	`this.keepAliveTimeout = 5000;`
`79`	`79`	`this.maxHeadersCount = null;`
`80`		`- this.headersTimeout = 40 * 1000; // 40 seconds`
	`80`	`+ this.headersTimeout = 60 * 1000; // 60 seconds`
`81`	`81`	`}`
`82`	`82`	`ObjectSetPrototypeOf(Server.prototype, tls.Server.prototype);`
`83`	`83`	`ObjectSetPrototypeOf(Server, tls.Server);`