test: fix tap escaping with and without --test

pulkit-30 · juanarbol · commit 32b020cf84ca · 2023-03-04T23:03:33.000-05:00
PR-URL: #46311 Backport-PR-URL: #46839 Fixes: #45836 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/internal/test_runner/reporter/tap.js b/lib/internal/test_runner/reporter/tap.js
@@ -132,14 +132,14 @@ function indent(nesting) {
 
 // In certain places, # and \ need to be escaped as \# and \\.
 function tapEscape(input) {
-  let result = StringPrototypeReplaceAll(input, '\\', '\\\\');
-  result = StringPrototypeReplaceAll(result, '#', '\\#');
-  result = StringPrototypeReplaceAll(result, '\b', '\\b');
+  let result = StringPrototypeReplaceAll(input, '\b', '\\b');
   result = StringPrototypeReplaceAll(result, '\f', '\\f');
   result = StringPrototypeReplaceAll(result, '\t', '\\t');
   result = StringPrototypeReplaceAll(result, '\n', '\\n');
   result = StringPrototypeReplaceAll(result, '\r', '\\r');
   result = StringPrototypeReplaceAll(result, '\v', '\\v');
+  result = StringPrototypeReplaceAll(result, '\\', '\\\\');
+  result = StringPrototypeReplaceAll(result, '#', '\\#');
   return result;
 }
 
diff --git a/test/message/test_runner_output.out b/test/message/test_runner_output.out
@@ -346,8 +346,8 @@ ok 36 - functionAndOptions # SKIP
   ---
   duration_ms: *
   ...
-# Subtest: escaped description \\ \# \\\#\\ \n \t \f \v \b \r
-ok 37 - escaped description \\ \# \\\#\\ \n \t \f \v \b \r
+# Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
+ok 37 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
   ---
   duration_ms: *
   ...
diff --git a/test/message/test_runner_output_cli.out b/test/message/test_runner_output_cli.out
@@ -122,9 +122,9 @@ TAP version 13
       failureType: 'testCodeFailure'
       error: |-
         Expected values to be strictly equal:
-        
+
         true !== false
-        
+
       code: 'ERR_ASSERTION'
       expected: false
       actual: true
@@ -345,8 +345,8 @@ TAP version 13
       ---
       duration_ms: *
       ...
-    # Subtest: escaped description \\ \# \\\#\\ n \\t f \\v b \\r
-    ok 37 - escaped description \\ \# \\\#\\ n \\t f \\v b \\r
+    # Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
+    ok 37 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
       ---
       duration_ms: *
       ...
