util: move util.isBoolean to eol

marco-ippolito · nodejs-github-bot · commit be528ab11e55 · 2024-05-06T09:37:58.000Z
PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -996,6 +996,9 @@ instead.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1011,9 +1014,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isBoolean()`][] API is deprecated. Please use
+The `util.isBoolean()` API has been removed. Please use
 `typeof arg === 'boolean'` instead.
 
 ### DEP0046: `util.isBuffer()`
@@ -3776,7 +3779,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
 [`util.inspect()`]: util.md#utilinspectobject-options
 [`util.inspect.custom`]: util.md#utilinspectcustom
 [`util.isArray()`]: util.md#utilisarrayobject
-[`util.isBoolean()`]: util.md#utilisbooleanobject
 [`util.isBuffer()`]: util.md#utilisbufferobject
 [`util.isDate()`]: util.md#utilisdateobject
 [`util.isError()`]: util.md#utiliserrorobject
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -2950,31 +2950,6 @@ util.isArray({});
 // Returns: false
 ```
 
-### `util.isBoolean(object)`
-
-<!-- YAML
-added: v0.11.5
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated: Use `typeof value === 'boolean'` instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is a `Boolean`. Otherwise, returns `false`.
-
-```js
-const util = require('node:util');
-
-util.isBoolean(1);
-// Returns: false
-util.isBoolean(0);
-// Returns: false
-util.isBoolean(false);
-// Returns: true
-```
-
 ### `util.isBuffer(object)`
 
 <!-- YAML
diff --git a/lib/util.js b/lib/util.js
@@ -91,15 +91,6 @@ function lazyAbortController() {
 
 let internalDeepEqual;
 
-/**
- * @deprecated since v4.0.0
- * @param {any} arg
- * @returns {arg is boolean}
- */
-function isBoolean(arg) {
-  return typeof arg === 'boolean';
-}
-
 /**
  * @deprecated since v4.0.0
  * @param {any} arg
@@ -419,9 +410,6 @@ module.exports = {
   isArray: deprecate(ArrayIsArray,
                      'The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.',
                      'DEP0044'),
-  isBoolean: deprecate(isBoolean,
-                       'The `util.isBoolean` API is deprecated.  Please use `typeof arg === "boolean"` instead.',
-                       'DEP0045'),
   isBuffer: deprecate(isBuffer,
                       'The `util.isBuffer` API is deprecated. Please use `Buffer.isBuffer()` instead.',
                       'DEP0046'),
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
@@ -102,11 +102,6 @@ assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
 assert.strictEqual(util.isBuffer('foo'), false);
 assert.strictEqual(util.isBuffer(Buffer.from('foo')), true);
 
-// deprecated
-assert.strictEqual(util.isBoolean(true), true);
-assert.strictEqual(util.isBoolean(false), true);
-assert.strictEqual(util.isBoolean('string'), false);
-
 assert.strictEqual(util.isNull(null), true);
 assert.strictEqual(util.isNull(undefined), false);
 assert.strictEqual(util.isNull(), false);
