pr_checker: ignore private emails

joyeecheung · joyeecheung · commit a254c82cce01 · 2017-11-23T23:01:58.000+08:00
diff --git a/lib/pr_checker.js b/lib/pr_checker.js
@@ -263,6 +263,13 @@ class PRChecker {
 
   isOddAuthor(commit) {
     const { pr, collaboratorEmails } = this;
+
+    // They have turned on the private email feature, can't really check
+    // anything, GitHub should know how to link that, see nodejs/node#15489
+    if (!pr.author.email) {
+      return false;
+    }
+
     // If they have added the alternative email to their account,
     // commit.authoredByCommitter should be set to true by Github
     if (commit.authoredByCommitter) {
