Add units option for "Stability margin" in plot dialog #2221#2965
Draft
luisroliveira wants to merge 2 commits into
Draft
Add units option for "Stability margin" in plot dialog #2221#2965luisroliveira wants to merge 2 commits into
luisroliveira wants to merge 2 commits into
Conversation
Contributor
|
Looks very nice |
Contributor
|
Is it possible you haven't committed all your changes? When I plot stability margin in %, I get a stability margin that's virtually 0. |
Contributor
|
@luisroliveira , do you have any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit selection support for the Stability Margin parameter in the simulation plot dialog.
Previously, the Y-axis type was labeled “Stability Margin Calibers”, which offered no unit choice. Now, the parameter has been renamed “Stability Margin” and provides two unit options:
Changes
Added a new TYPE_STABILITY FlightDataType linked to the new unit group.
Integrated with FlightDataTypeGroup.STABILITY.
Created UNITS_STABILITY_SELECT_PLOT UnitGroup.
Added cal and % as selectable units for Stability Margin.
Updated messages to reflect the new display name and units in the plot dialog.