Fixed an off-by-one error in _PyUnicode_EqualToASCIIString (issue #28701).

serhiy-storchaka · serhiy-storchaka · commit 292dd1b2ad51 · 2016-11-16T16:12:34.000+02:00
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -10846,7 +10846,7 @@ non_ready_unicode_equal_to_ascii_string(PyObject *unicode, const char *str)
     assert(p);
     for (i = 0; i < len; i++) {
         unsigned char c = (unsigned char)str[i];
-        if (c > 128 || p[i] != (wchar_t)c)
+        if (c >= 128 || p[i] != (wchar_t)c)
             return 0;
     }
     return 1;

Original file line number	Diff line number	Diff line change
`@@ -10846,7 +10846,7 @@ non_ready_unicode_equal_to_ascii_string(PyObject unicode, const char str)`
`10846`	`10846`	`assert(p);`
`10847`	`10847`	`for (i = 0; i < len; i++) {`
`10848`	`10848`	`unsigned char c = (unsigned char)str[i];`
`10849`		`- if (c > 128 \|\| p[i] != (wchar_t)c)`
	`10849`	`+ if (c >= 128 \|\| p[i] != (wchar_t)c)`
`10850`	`10850`	`return 0;`
`10851`	`10851`	`}`
`10852`	`10852`	`return 1;`