Skip to content

Removed deprecated draw#485

Merged
eriknw merged 1 commit into
python-graphblas:mainfrom
paul-tqh-nguyen:paulnguyen/rm_deprecated_0
Jul 26, 2023
Merged

Removed deprecated draw#485
eriknw merged 1 commit into
python-graphblas:mainfrom
paul-tqh-nguyen:paulnguyen/rm_deprecated_0

Conversation

@paul-tqh-nguyen

Copy link
Copy Markdown
Contributor

No description provided.

@eriknw

eriknw commented Jul 22, 2023

Copy link
Copy Markdown
Member

Thanks @paul-tqh-nguyen, welcome as a contributor!

Oh, looks like we did miss a usage of gb.io.draw in the docs. docs/api_reference/io.rst uses graphblas.io.draw. Maybe change that to graphblas.viz.draw or just remove it. Visualization probably deserves its own page.

@coveralls

coveralls commented Jul 22, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 99.376% (+0.3%) from 99.107% when pulling 46209e8 on paul-tqh-nguyen:paulnguyen/rm_deprecated_0 into 8bd80f6 on python-graphblas:main.

@paul-tqh-nguyen paul-tqh-nguyen force-pushed the paulnguyen/rm_deprecated_0 branch from 095388d to 46209e8 Compare July 26, 2023 14:07
@paul-tqh-nguyen

Copy link
Copy Markdown
Contributor Author

I made the minimal change needed to pass CI. I think making a dedicated viz page would make sense, but it probably out of the scope of this PR.

@eriknw

eriknw commented Jul 26, 2023

Copy link
Copy Markdown
Member

LGTM, thanks @paul-tqh-nguyen--welcome as a contributor!

@eriknw eriknw merged commit ae0366a into python-graphblas:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants