Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

_get_output_enabled() in agilent2000A.py changes _output_standard_waveform_amplitude #14

Description

@matthewrankin

While adding unit tests for the agilentMSOX3024A.py file and its parents, I found what appears to be an error in the _get_output_enabled() function in agilent2000A.py.

def _get_output_enabled(self, index):
    index = ivi.get_index(self._output_name, index)
    if not self._driver_operation_simulate and not self._get_cache_valid(index=index):
        resp = self._ask(":%s:output?" % self._output_name[index])
        self._output_standard_waveform_amplitude[index] = bool(int(resp))
        self._set_cache_valid(index=index)
    return self._output_enabled[index]

Instead of setting _output_standard_waveform_amplitude[index] to the scope's response, I think that should set _output_enabled[index].

Note — If you run _set_output_enabled() prior to _get_output_enabled(), you'll get the proper response, since the _set_output_enabled() function does change the _output_enabled[index] variable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions