Skip to content

Ensure only implementers of IEnumerable or IEnumerator are considered Iterable#1241

Merged
lostmsu merged 2 commits into
pythonnet:masterfrom
danabr:iterable
Sep 29, 2020
Merged

Ensure only implementers of IEnumerable or IEnumerator are considered Iterable#1241
lostmsu merged 2 commits into
pythonnet:masterfrom
danabr:iterable

Conversation

@danabr

@danabr danabr commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

Does this close any currently open issues?

Fixes #1234.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-commenter

codecov-commenter commented Sep 27, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1241   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40           
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451fae6...cec559c. Read the comment docs.

@filmor filmor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, looks good to me.

@lostmsu Can you have a look as well?

Mid-term we should probably just fill the slots explicitly instead of picking up methods by name.

Comment thread src/runtime/typemanager.cs Outdated
@lostmsu lostmsu merged commit b5ba815 into pythonnet:master Sep 29, 2020
@lostmsu

lostmsu commented Sep 29, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET class instances considered Iterable

4 participants