Add gradle.properties file for nullaway-bom module#1383
Conversation
WalkthroughThis pull request adds a new Gradle properties file at Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
nullaway-bom/gradle.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build caffeine with snapshot
- GitHub Check: Build and test on windows-latest
- GitHub Check: Build and test on macos-latest
🔇 Additional comments (2)
nullaway-bom/gradle.properties (2)
1-15: LGTM.The Apache 2.0 license header is correctly formatted and consistent with license requirements.
17-18: The property namesPOM_NAMEandPOM_ARTIFACT_IDfollow standard Gradle naming conventions. Verify that the build configuration consumes these properties correctly before merging.
| POM_NAME=NullAway | ||
| POM_ARTIFACT_ID=nullaway-bom | ||
| POM_PACKAGING=jar |
There was a problem hiding this comment.
Change POM_PACKAGING from "jar" to "pom" for the BOM module.
A BOM artifact requires packaging type pom, not jar, to qualify as a proper BOM with the POM file explicitly specifying <packaging>pom</packaging> in its metadata. This is essential for Maven Central compliance and proper BOM functionality.
-POM_PACKAGING=jar
+POM_PACKAGING=pom🤖 Prompt for AI Agents
In nullaway-bom/gradle.properties around lines 17 to 19, the BOM module is
incorrectly set with POM_PACKAGING=jar; change the packaging value to
POM_PACKAGING=pom so the artifact is produced as a BOM (packaging pom) and
metadata will include <packaging>pom</packaging>, ensuring Maven Central
compliance and correct BOM behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
=========================================
Coverage 88.35% 88.35%
Complexity 2642 2642
=========================================
Files 97 97
Lines 8888 8888
Branches 1775 1775
=========================================
Hits 7853 7853
Misses 518 518
Partials 517 517 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This ensures the generated pom has a project name, required by Maven Central
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.