[dev] C7 - Configs refactor: finalize and simplify infrastructure #3354
Draft
deruyter92 wants to merge 20 commits into
Draft
[dev] C7 - Configs refactor: finalize and simplify infrastructure #3354deruyter92 wants to merge 20 commits into
deruyter92 wants to merge 20 commits into
Conversation
Collaborator
Author
|
@C-Achard, would be very helpful if you could give an intermediate review on the deeplabcut.core.config module and corresponding tests. (diff with main, there are some intermediate states that are irrelevant). Thanks a lot!! |
C-Achard
reviewed
Jun 4, 2026
Collaborator
C-Achard
left a comment
There was a problem hiding this comment.
@deruyter92 Here are some first comments, mostly focusing on usability/possible refactor artifacts.
Note that I only reviewed the diff of C7 to the feature branch; happy to review the full version once this is finalized.
deruyter92
commented
Jun 5, 2026
Collaborator
Author
deruyter92
left a comment
There was a problem hiding this comment.
Thanks @C-Achard. Addressed all your comments. Let's discuss next week.
I have a few extra adjustments in mind (better hook-up in codebase), but after that it's ready for proper stress-testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the WIP (see #3198) for migrating from dictionary configs to typed & validated configurations (overview is tracked in #3193).
This PR finalizes, cleans and simplifies the infrastructure for structured configs before moving migrating to the structured config (schema V1).
Changes: