Update to swift 4#54
Merged
Merged
Conversation
AYastrebov
commented
Mar 11, 2018
Contributor
- update to swift 4
- carthage support for swift 4
Owner
|
Hey @AYastrebov thanks for this PR, looks good to me 👌 Could you just add an entry in the (Just format them the same as the previous entries — just don't forget to add two spaces at the end of the line after the ending period |
AliSoftware
requested changes
Mar 12, 2018
Owner
There was a problem hiding this comment.
-
Could you also update the
README.md?- change the "Requirements" section to add Swift 4 to supported versions
- edit the shields.io' Badge used just above that
# Requirementstitle, to change it to something like[](https://swift.org):
-
Also please add an entry to the
CHANGELOG.mdto credit yourself 👍
Thanks!
Contributor
Author
|
@AliSoftware sure, will make it asap |
Contributor
Author
|
I've updated the PR. Also pushed a new tag |
Owner
|
Cool thanks, I'll try to merge & do a release in the afternoon 👍 |
AliSoftware
approved these changes
Mar 15, 2018
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.