DPL Analysis: shortcircuit creation of empty slices#15480
Merged
Conversation
Member
Author
|
@aalkin what do you think of this? |
Member
|
Seems like a good idea, a single allocation for an empty slice and a single construction of the table object that is reused for the full loop. How much is gained from this? |
Empty slices still do one allocation per column, so this is particularly bad when there are many empty groups.
Member
Author
|
Validation report when running on the same file locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty slices still do one allocation per column, so this is particularly
bad when there are many empty groups.