add local to-do planner / tasks to calendar overvie…#2583
Conversation
|
This looks so cool! Some feedback from the video if you want more insight:
|
|
@hthienloc i have made some changes since your recommendations and do tell me if this is what you envisioned |
|
@hthienloc i have tried to make the changes you suggested and this is what i came up with, feel free to give more suggestions on possible improvements i can make |
Purian23
left a comment
There was a problem hiding this comment.
Thanks for the PR @goatnath, it looks really cool! Good feedback, @hthienloc!
I'm glad khal support is optional, it's likely getting deprecated or changed in our upcoming dank calendar release.
Otherwise, there are a few issues to address here:
-
The PR currently prevents DMS from starting because
CalendarOverviewCard.qmlis missing a closing}near line 958. -
When khal finishes loading, it replaces
eventsByDateand can wipe out tasks loaded earlier. Keeping local tasks andkhalevents separately, then merging them, would avoid this race. -
The separate Python CRUD processes can run concurrently and overwrite each other’s changes. A single in-memory model backed by an atomic
FileViewwrite would also remove the Python dependency. -
Several delegate bindings access
modelDatawithout checking whether it is null, which can produce QMLTypeErrorwarnings during model updates. -
Completion is already stored as a boolean, so task titles should remain clean. A
completedproperty andDankIconwould avoid adding and later parsing Unicode checkbox characters. -
During dragging, animation is disabled for every item. Disabling it only on the dragged item would let neighboring tasks move smoothly.
-
The reorder fallback checks IDs against
id_to_item, which contains every task, so omitted tasks can be silently dropped. It should check against the submitted ordered IDs instead.
There is also trailing whitespace in both changed files, although make lint-qml otherwise passes. Once these issues and the syntax error are fixed, we’ll be glad to take another look.
…remove python dependency
|
@Purian23 I have made a few changes , even though i don't completely understand all the errors as i'm still new to this stuff but do check how it does now in the pre-commit checks. |

Description
into the Calendar card in the Quickshell overview tab. It allows users to
click on any calendar day to add, toggle, and delete daily tasks locally.
If
khalis installed, these local planner tasks are displayed alongsidecalendar events; if
khalis not installed, the Calendar card remainsfully functional as a standalone local to-do planner rather than
displaying as empty.
recording.mp4
context, reusing existing terms where possible
- [ ] Go changes: ran
make fmt, added/updated tests,make testpasses, and
go mod tidyis clean- [x] My QML changes: ran
make lint-qmlwith no new warnings- [ ] I have opened a corresponding pull request in dlx-docs to document
any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs