fix(ui): use primaryText instead of primary for text and icons displayed on primaryContainer background in the launcher#2586
Open
Silzinc wants to merge 1 commit into
Conversation
…yed on primaryContainer background in the launcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With my current background, the theme generated makes the selected mode button unreadable in the DMS launcher. I changed a few colors to solve this.
This could be a matter of taste and still not work for all generated themes, I just thought that it made more sense to have
primaryTextrather thanprimaryon top ofprimaryContainer.There are other places in the code where
primaryis used onprimaryContainer, but I could not find the corresponding elements in the DMS UI so I made no change I could not test.Type of change
Screenshots / video
before.mp4
after.mp4
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings