Skip to content

fix(ui): use primaryText instead of primary for text and icons displayed on primaryContainer background in the launcher#2586

Open
Silzinc wants to merge 1 commit into
AvengeMedia:masterfrom
Silzinc:primaryText-on-primaryContainer
Open

fix(ui): use primaryText instead of primary for text and icons displayed on primaryContainer background in the launcher#2586
Silzinc wants to merge 1 commit into
AvengeMedia:masterfrom
Silzinc:primaryText-on-primaryContainer

Conversation

@Silzinc
Copy link
Copy Markdown
Contributor

@Silzinc Silzinc commented Jun 6, 2026

Description

With my current background, the theme generated makes the selected mode button unreadable in the DMS launcher. I changed a few colors to solve this.

This could be a matter of taste and still not work for all generated themes, I just thought that it made more sense to have primaryText rather than primary on top of primaryContainer.

There are other places in the code where primary is used on primaryContainer, but I could not find the corresponding elements in the DMS UI so I made no change I could not test.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Screenshots / video

before.mp4
after.mp4

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • [N/A] New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • [N/A] Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • [N/A] I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

…yed on primaryContainer background in the launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant