fix(frame): add widget end inset for edge widgets when Frame is enabled#2600
Open
ultherego wants to merge 1 commit into
Open
fix(frame): add widget end inset for edge widgets when Frame is enabled#2600ultherego wants to merge 1 commit into
ultherego wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Frame is enabled, edge widgets on both ends of the bar had no inset from the frame corners — _frameLeftInset/_frameRightInset (horizontal bar) and _frameTopInset/_frameBottomInset (vertical bar) fell back to 0 when no adjacent bar was present, causing widgets to sit flush against the frame.
Fixed by introducing _frameEndInset = frameThickness + frameBarEndInset as the fallback value. Also added a Widget End Inset slider in Settings → Frame → Border (default 0, range 0–20px) so users can add extra padding on top of frameThickness.
Type of change
Related issues
Fixes #2597
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings