Skip to content

fix(frame): add widget end inset for edge widgets when Frame is enabled#2600

Open
ultherego wants to merge 1 commit into
AvengeMedia:masterfrom
ultherego:fix/frame-widget-end-inset
Open

fix(frame): add widget end inset for edge widgets when Frame is enabled#2600
ultherego wants to merge 1 commit into
AvengeMedia:masterfrom
ultherego:fix/frame-widget-end-inset

Conversation

@ultherego
Copy link
Copy Markdown

Description

When Frame is enabled, edge widgets on both ends of the bar had no inset from the frame corners — _frameLeftInset/_frameRightInset (horizontal bar) and _frameTopInset/_frameBottomInset (vertical bar) fell back to 0 when no adjacent bar was present, causing widgets to sit flush against the frame.
Fixed by introducing _frameEndInset = frameThickness + frameBarEndInset as the fallback value. Also added a Widget End Inset slider in Settings → Frame → Border (default 0, range 0–20px) so users can add extra padding on top of frameThickness.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Fixes #2597

Screenshots / video

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connected frame: bar widget inset lost after restart (Edge Spacing ignored with Frame on)

1 participant