chore(sdk-lib-mpc): bump @bitgo/wasm-mps to 1.10.0#9147
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
chore(sdk-lib-mpc): bump @bitgo/wasm-mps to 1.10.0#9147bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Contributor
12947a6 to
5ba7d50
Compare
3 tasks
9083604 to
9407614
Compare
Bump @bitgo/wasm-mps from 1.8.1 to 1.10.0. wasm-mps 1.10.0 changes DSG path derivation from the old Silence Labs formula to standard BIP32-Ed25519, matching Eddsa.deriveUnhardened. Update all DSG cross-check tests and the signRecoveryEddsaMPCv2 helper to use Eddsa.deriveUnhardened instead of the now-incompatible deriveUnhardenedMps: - sdk-lib-mpc/test: replace the old deriveUnhardenedMps DSG cross-check block with new tests that verify against Ed25519Bip32HdTree.publicDerive (i.e. Eddsa.deriveUnhardened). Remove the commented-out old block. - sdk-core/src: make signRecoveryEddsaMPCv2 async; derive the expected public key via getInitializedMpcInstance().deriveUnhardened instead of deriveUnhardenedMps. Drop the deriveUnhardenedMps import. - sdk-core/test: await signRecoveryEddsaMPCv2; verify against mpc.deriveUnhardened; use assert.rejects for the async throw test; drop deriveUnhardenedMps import; change path from m/0/0 to m/0. This is a prerequisite for WCI-644 (full removal of deriveUnhardenedMps). Ticket: WCI-793 Session-Id: 01cf0284-3429-472d-8205-b7ef491d6426 Task-Id: 2a3decb6-9318-4219-94b3-21a0acdfebfb
72f3f26 to
f1c841e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@bitgo/wasm-mpsfrom1.8.1to1.10.0in@bitgo/sdk-lib-mpcyarn.lockentryWhy
@bitgo/wasm-mpsintroduces backwards-compatible BIP32 derivation in MPS signing, aligning DSG path derivation with the standard Ed25519 BIP32 formula (Eddsa.deriveUnhardened)deriveUnhardenedMpsworkaround and consolidates all MPCv1/MPCv2 derivation to a unified methodTest plan
@bitgo/sdk-lib-mpcpass@bitgo/sdk-corepassTicket: WCI-793