chore(sdk-lib-mpc): bump @bitgo/wasm-mps to 1.10.0#9149
Closed
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Closed
chore(sdk-lib-mpc): bump @bitgo/wasm-mps to 1.10.0#9149bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Upgrade @bitgo/wasm-mps from 1.8.1 to 1.10.0 in sdk-lib-mpc. Version 1.10.0 changes the key derivation algorithm used internally by ed25519_dsg_round0_process from the Silence Labs custom BIP32 formula to the standard Cardano BIP32-Ed25519 formula (the same one used by Eddsa.deriveUnhardened). This enables consistent use of deriveUnhardened across both the TSS protocol and address derivation, and supports the backwards-compatible BIP32 derivation in MPS sign required by HSM-384. Update the DSG cross-check tests in derive.ts to verify signatures against the BIP32-derived public key (via Ed25519Bip32HdTree) rather than the old Silence Labs formula in deriveUnhardenedMps, which no longer matches the WASM derivation after this bump. Ticket: WCI-880 Session-Id: bd2446e4-30fa-4159-b66d-6f3c9027f98f Task-Id: d9d634c8-6aea-446a-8c3b-c33dc8672961
Contributor
3639a31 to
6266f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@bitgo/wasm-mpsfrom1.8.1to1.10.0inmodules/sdk-lib-mpc/package.jsonyarn.lockwith the new resolved URL and integrity hash for1.10.0derive.tsto verify against the BIP32-derived public key (Ed25519Bip32HdTree) instead of the old Silence Labs formula (deriveUnhardenedMps), which no longer matches the WASM derivation after this bumpWhy
wasm-mps1.10.0 changes the key derivation algorithm used internally byed25519_dsg_round0_processfrom the Silence Labs custom BIP32 formula to the standard Cardano BIP32-Ed25519 formula (same asEddsa.deriveUnhardened). This is required to support backwards-compatible BIP32 derivation in MPS sign (HSM-384) and enables consistent use ofderiveUnhardenedacross both the TSS signing protocol and address derivation, removing the need for thederiveUnhardenedMpsworkaround.Test plan
yarn buildinmodules/sdk-lib-mpcsucceeds with no TypeScript errorsyarn unit-testinmodules/sdk-lib-mpcpasses: 161 passing, 0 failingyarn.lockupdated with correct resolved URL and integrity hash for@bitgo/wasm-mps@1.10.0Ticket: WCI-880