fix: limit AST recursion depth to 20 in Python parser (#1095)#1129
Open
ayush-kr-repo wants to merge 1 commit into
Open
fix: limit AST recursion depth to 20 in Python parser (#1095)#1129ayush-kr-repo wants to merge 1 commit into
ayush-kr-repo wants to merge 1 commit into
Conversation
|
@ayush-kr-repo is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
d99e9df to
9f34202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deeply nested, autogenerated, or cyclical Python source files trigger
Python's recursion limit in the AST parsing loop, causing the parser
pipeline to crash.
Fix
MAX_DEPTH = 20guard in_get_parent_contextto stoptraversing parent nodes beyond 20 levels
depthcounter in_calculate_complexity'straversefunction to skip AST branches beyond 20 levels deep
warning_loggerwhen the limit is hitTests
Added 2 new tests in
tests/unit/parsers/test_python_parser.py:test_ast_recursion_depth_limit_parent_context— 25-level nested functionstest_ast_recursion_depth_limit_complexity— 25-level nested if-statementsAll 5 tests passing locally.
Closes #1095