London | 26-SDC-Mar | Beko | Sprint 4 | Implement Shell Tools#501
London | 26-SDC-Mar | Beko | Sprint 4 | Implement Shell Tools#501Abubakar-Meigag wants to merge 3 commits into
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there is some work left to do here.
Is there a package you could use to help with managing arguments? Right now it doesn't offer any help text, and you can't combine single-letter arguments like the command line tools.
Implement -1 for the ls file exercises
LonMcGregor
left a comment
There was a problem hiding this comment.
Great. One one other thing I have noticed is there is a lot of repetition in the structure at the end of the word counts file. Can you find a way to reduce that duplication?
update for code review
it's done now, you could check it, thanks |
LonMcGregor
left a comment
There was a problem hiding this comment.
Thanks for changing this - reducing duplication is always something worth keeping an eye out for
Self checklist
Complete shell tools exercises for sprint 4 in Python