Native dependencies, better behaviour on non-Windows#54
Merged
Conversation
Also build NuGet
Better to tell people to use Brew themselves on macOS?
Contributor
Author
|
Note, for macOS, I've found that the included dylib isn't enough to work on macOS, I get: If I instead install with Homebrew: (which brew won't link globally "Warning: Refusing to link macOS-provided software: openblas") then go ahead an link locally in a project I get everything working. So the choice seems to be to package more of these files or rely on the end-user. @erydo I saw that you did some work on this, any suggestions on the best approach? I'm going to default to leaving it in the end-users responsibility. That's what the last released NuGet did. |
Contributor
Author
|
Merging this to provide a test release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only copy the Windows native dlls when on Windows
Adjust the Homebrew command for where openblas is now