use NoInfer on predicate parameter in recurWhile, recurUntil, collectWhile, collectUntil#6262
Open
harsha-cpp wants to merge 1 commit into
Open
Conversation
…While, collectUntil
🦋 Changeset detectedLatest commit: 9fe7d8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6251.
problem:
Schedule.recurWhile((data) => data === "foo"`` infersdataasunknowninstead of the success type when used insideEffect.repeat. TypeScript eagerly resolvesAfromf: Predicate` at the call site where there's no contextual type for the predicate parameter.fix: wrap the predicate with
NoInfer<A>on the four public signatures with this shape. TypeScript stops inferringAfrom the predicate and picks it up from theInchannel of the surroundingrepeatinstead.type test added in
dtslint/Schedule.tst.ts.