Skip to content

Further clean up after PR 1719 for Nano Every#1720

Merged
zackees merged 4 commits into
FastLED:masterfrom
ngyl88-arduino:fix-nano-every-build
Sep 19, 2024
Merged

Further clean up after PR 1719 for Nano Every#1720
zackees merged 4 commits into
FastLED:masterfrom
ngyl88-arduino:fix-nano-every-build

Conversation

@ngyl88
Copy link
Copy Markdown
Contributor

@ngyl88 ngyl88 commented Sep 19, 2024

Changes:

  1. Complete removal of ARDUINO_AVR_NANO_EVERY conditionals from fastpin_avr.h to avoid unintentional overwriting pin definition. Arduino Nano Every is subset of ATmega4809 .
  2. Extract file fastpin_avr_atmega4809.h from fastpin_avr.h

More details on:

ngyl88 and others added 4 commits September 19, 2024 09:52
- to complete removal of arduiono nano every due to atmega4809 (avoid potential overwriting)
- enable nano every build on working branch

fix invalid syntax
@ngyl88
Copy link
Copy Markdown
Contributor Author

ngyl88 commented Sep 19, 2024

@zackees could you help to review this ?

BTW are you able to configure the reviewer list for this repo? We don't see any reviewer after creating the PR.

@zackees zackees merged commit 3cdcdef into FastLED:master Sep 19, 2024
@zackees
Copy link
Copy Markdown
Member

zackees commented Sep 19, 2024

I do not have the ability. But you are free to @ me so that I see it.

Please squash your commits so that there is only one commit in the future. It's extremely hard to follow a CL when there are X number of commits to it.

@ngyl88
Copy link
Copy Markdown
Contributor Author

ngyl88 commented Sep 19, 2024

Okay, I will squash all commits into one in the future. Usually, I grouped my commit through squash and rebase, eg. d0423f2. I leave it as separate commits when context are separate, so that it's easier to trace the history when merged into the master branch.

All changes regardless of commits could be seen at https://github.com/FastLED/FastLED/pull/1720/files .

Anyway, thanks for the quick merge , @zackees ! 😄

@ngyl88 ngyl88 deleted the fix-nano-every-build branch September 19, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants