Skip to content

Set-VSTeamVariableGroupVariable cmdlet, tests, docs#495

Merged
SebastianSchuetze merged 9 commits into
MethodsAndPractices:trunkfrom
sevaa:feature_setvar
May 11, 2023
Merged

Set-VSTeamVariableGroupVariable cmdlet, tests, docs#495
SebastianSchuetze merged 9 commits into
MethodsAndPractices:trunkfrom
sevaa:feature_setvar

Conversation

@sevaa

@sevaa sevaa commented Nov 9, 2022 •
edited by SebastianSchuetze
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Addresses #423

PR Checklist

@sevaa sevaa mentioned this pull request Nov 9, 2022
Closed
@SebastianSchuetze SebastianSchuetze linked an issue Nov 10, 2022 that may be closed by this pull request
Update Single Variable #423
Closed
SebastianSchuetze
SebastianSchuetze suggested changes Nov 10, 2022
View reviewed changes

@SebastianSchuetze SebastianSchuetze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I added my comments to the code lines. Just some minor things to make the code cleaner and more maintainable in the future.

Comment thread .docs/Set-VSTeamVariableGroupVariable.md Outdated
Comment thread .docs/synopsis/Set-VSTeamVariableGroupVariable.md Outdated
Comment thread .docs/Set-VSTeamVariableGroupVariable.md Outdated
Comment thread Source/Public/Set-VSTeamVariableGroupVariable.ps1
Comment thread Source/Public/Set-VSTeamVariableGroupVariable.ps1
Comment thread Source/Public/Set-VSTeamVariableGroupVariable.ps1 Outdated
Comment thread Source/Public/Set-VSTeamVariableGroupVariable.ps1 Outdated
Comment thread Tests/function/tests/Set-VSTeamVariableGroupVariable.Tests.ps1
@sevaa

sevaa commented Nov 10, 2022

Copy link
Copy Markdown
Contributor Author

Addressed most. Please take another look.

@sevaa sevaa mentioned this pull request Nov 10, 2022
Merged
3 tasks
@sevaa

sevaa commented Nov 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

What are my next steps, please?

The group search by name is broken (obscure exception if not found), the double JSON convert can be avoided but the review doesn't say so, just asks why.

@sevaa

sevaa commented Dec 5, 2022

Copy link
Copy Markdown
Contributor Author

Is this PR a lost cause? If so, please let me know. As outlined in #423, I'll go ahead and publish as a separate PowerShell module.

@sevaa

sevaa commented Jan 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Any update please? Any maintainers present? I think I've made all the changes needed - but the PR still says "Changes requested". @SebastianSchuetze @DarqueWarrior

@sevaa

sevaa commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

@SebastianSchuetze What should be my actions now?

@SebastianSchuetze

SebastianSchuetze commented May 11, 2023

Copy link
Copy Markdown
Contributor

Thanks for the help! Gonna merge it.

@SebastianSchuetze SebastianSchuetze merged commit 01832eb into MethodsAndPractices:trunk May 11, 2023
@sevaa sevaa deleted the feature_setvar branch May 11, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SebastianSchuetze SebastianSchuetze SebastianSchuetze left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Single Variable

2 participants

@sevaa @SebastianSchuetze