Skip to content

[None][infra] Waive TestQwen3NextInstruct nvfp4 cases#15086

Open
mzweilz wants to merge 1 commit into
NVIDIA:mainfrom
mzweilz:waive-qwen3next-nvfp4
Open

[None][infra] Waive TestQwen3NextInstruct nvfp4 cases#15086
mzweilz wants to merge 1 commit into
NVIDIA:mainfrom
mzweilz:waive-qwen3next-nvfp4

Conversation

@mzweilz
Copy link
Copy Markdown
Collaborator

@mzweilz mzweilz commented Jun 8, 2026 •
edited by coderabbitai Bot
Loading

https://nvbugs/6281014

Summary by CodeRabbit

  • Tests
    • Added two skipped test cases with different configurations to the test configuration list.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@mzweilz
[None][infra] Waive TestQwen3NextInstruct nvfp4 cases
dca76ef 
https://nvbugs/6281014
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
@mzweilz mzweilz force-pushed the waive-qwen3next-nvfp4 branch from 6cc518c to dca76ef Compare June 8, 2026 06:44
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 8, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4055b76c-1f48-4459-b8b3-d87d60b3296c

📥 Commits

Reviewing files that changed from the base of the PR and between 7e49baa and 6cc518c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

Two new waiver entries are added to the test skip list for TestQwen3NextInstruct::test_nvfp4 with different configuration parameters (no_cuda_graph_overlap-cutlass and tp4ep1-cutlass), both referencing nvbug 6281014.

Changes

Test Skip List Waivers

Layer / File(s) Summary
NVFP4 test waivers for Qwen3NextInstruct
tests/integration/test_lists/waives.txt		 Two parameterized test variants for TestQwen3NextInstruct::test_nvfp4 are added to the skip list with distinct configuration strings and a shared nvbug reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14789: Both PRs update tests/integration/test_lists/waives.txt to add SKIP/waiver entries for failing accuracy/test_llm_api_pytorch.py nvfp4-related test cases referencing nvbugs.
  • NVIDIA/TensorRT-LLM#14787: Both PRs modify tests/integration/test_lists/waives.txt by adding SKIP entries for accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct variants with bug links.
  • NVIDIA/TensorRT-LLM#15077: Both PRs modify tests/integration/test_lists/waives.txt to add new waived integration test cases including additional TestQwen3NextInstruct waivers.

Suggested reviewers

  • xinhe-nv
  • ZhanruiSunCh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. Only the NVBugs reference is provided; required sections like Description, Test Coverage, and PR Checklist remain unfilled with only template placeholders. Complete the Description section explaining the issue and rationale, add Test Coverage details, and review the PR Checklist items. At minimum, explain why these test cases are being waived and reference the NVBugs ticket in the description section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: waiving (skipping) specific TestQwen3NextInstruct nvfp4 test cases, follows the template format with [None][infra] prefix, and is clear and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mzweilz
Copy link
Copy Markdown
Collaborator Author

mzweilz commented Jun 8, 2026

/bot run --stage-list "GB200-4_GPUs-PyTorch-*"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Jun 8, 2026

PR_Github #52690 [ run ] triggered by Bot. Commit: dca76ef Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Jun 8, 2026

PR_Github #52690 [ run ] completed with state FAILURE. Commit: dca76ef
/LLM/main/L0_MergeRequest_PR pipeline #41957 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@mzweilz
Copy link
Copy Markdown
Collaborator Author

mzweilz commented Jun 8, 2026

/bot run --stage-list "GB200-4_GPUs-PyTorch-*"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Jun 8, 2026

PR_Github #52698 [ run ] triggered by Bot. Commit: dca76ef Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Jun 8, 2026

PR_Github #52698 [ run ] completed with state FAILURE. Commit: dca76ef
/LLM/main/L0_MergeRequest_PR pipeline #41966 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@mzweilz
Copy link
Copy Markdown
Collaborator Author

mzweilz commented Jun 8, 2026

/bot run --stage-list "GB200-4_GPUs-PyTorch-*"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Jun 8, 2026

PR_Github #52742 [ run ] triggered by Bot. Commit: dca76ef Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mzweilz mzweilz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mzweilz @tensorrt-cicd