fix(gui): support translator internal name in ENABLED_SERVICES config#1125
Open
octo-patch wants to merge 1 commit into
Open
Conversation
Allow ENABLED_SERVICES to match services by their internal translator name (e.g. "qwen-mt") in addition to their display name (e.g. "Ali Qwen-Translation"), so users can use either form in the config. Fixes PDFMathTranslate#1108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108
Problem
When configuring
ENABLED_SERVICESin the config file, users must use the UI display name (e.g."Ali Qwen-Translation") to enable a service. However, translators also have an internalnameattribute (e.g."qwen-mt"forQwenMtTranslator), which is the name used in thetranslatorslist of the config file. This mismatch is confusing — users naturally try using the same name ("qwen-mt") in bothENABLED_SERVICESandtranslators, but only thetranslatorslookup works with the internal name.Solution
Extend the
ENABLED_SERVICESfilter ingui.pyto match services by either their display name (the service_map key) or their translator internalnameattribute. This way both of the following configs work:Testing
"qwen-mt"now resolves to"Ali Qwen-Translation"in the service list