fix: guard against empty choices and message=None in OpenAI responses#1138
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty choices and message=None in OpenAI responses#1138qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
OpenAI-compatible APIs can return empty choices (IndexError) or choices[0].message=None when content is filtered (HTTP 200, AttributeError). Adds two-condition guard before bare choices[0].message.content accesses in 3 Translator subclasses (4 total sites, 3 were unguarded). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenAI-compatible APIs can fail silently in two ways:
IndexError):response.choicesis[]when the API returns no completionsmessage=None(AttributeError):response.choices[0].messageisNonewhen content is filtered (e.g., Gemini returns HTTP 200 withPROHIBITED_CONTENT,message=None)Both paths cause unhandled runtime exceptions during translation, aborting the entire translation job.
Affected code
Three
Translatorsubclasses inpdf2zh/translator.pyhave unguarded accesses (4 sites total — lines 549, 628, 631, 1198 in the original).Fix
Adds the standard two-condition guard before each bare
choices[0].message.contentaccess:This converts silent crashes into explicit, actionable errors with a clear message.
8 lines added, 0 deleted.
Verification
Detected by pact static analysis (
llm_response_unguardedrule). Confirmed: Gemini 2.5 Flash returns HTTP 200 withchoices[0].message=Noneon prohibited content.